test: update tests

Codeminer42 · Aug 12, 2024 · 9ca5cfe · 9ca5cfe
1 parent f7f0153
commit 9ca5cfe
Show file tree

Hide file tree

Showing 5 changed files with 139 additions and 79 deletions.
diff --git a/app/assets/javascripts/actions/story.js b/app/assets/javascripts/actions/story.js
@@ -222,9 +222,8 @@ export const dragDropStory =
     const newStory = Story.addNewAttributes(story, newAttributes);
 
     const storiesWithUpdatedPositions = Story.sortOptimistically(
-      stories,
-      newStory,
-      from
+      storiesWithScope(stories, from),
+      newStory
     );
 
     try {

diff --git a/app/assets/javascripts/models/beta/story.js b/app/assets/javascripts/models/beta/story.js
@@ -9,7 +9,6 @@ import StoryPropTypesShape, {
 import moment from 'moment';
 import { has } from 'underscore';
 import * as History from './history';
-import { storiesWithScope } from '../../reducers/stories';
 
 const compareValues = (a, b) => {
   if (a > b) return 1;
@@ -140,6 +139,9 @@ export const update = async (story, projectId, options) => {
 };
 
 export const getHighestNewPosition = stories => {
+  if (stories.length === 1) {
+    return 1;
+  }
   const highestPositionValue = stories
     .filter(story => story.newPosition !== null)
     .reduce((acc, story) => {
@@ -481,10 +483,9 @@ export const donePoints = stories =>
 export const remainingPoints = stories =>
   totalPoints(stories) - donePoints(stories);
 
-export const sortOptimistically = (stories, newStory, from) => {
-  const scopeStories = storiesWithScope(stories, from);
+export const sortOptimistically = (stories, newStory) => {
   const isChillyBinStory = isUnscheduled(newStory);
-  const targetStories = scopeStories.filter(
+  const targetStories = stories.filter(
     story => isUnscheduled(story) === isChillyBinStory
   );