This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
fix Decimal::fromFloat() with specified lower scale #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I've experienced some strange behavior of
Decimal::fromFloat()
when lowering the scale using the second parameter. I've provided additional tests and fixed the behavior usinginnerRound
so it's consistent withDecimal::fromString()
.Even though the last commit in this repo was created quite a while ago, I hope we can get it merged and released. Let me know if there's anything I can do to ease the merge process 🙂
The console output of the added tests with the current behavior describing the issue: