This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
feat: created CNPJ mask filter and applied it in Client model. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feat references the issue Coderockr#104 (Coderockr#104)
eminetto
reviewed
Oct 9, 2018
|
|
||
| class ApplicationTestCase extends PHPUnit_Framework_TestCase | ||
| class ApplicationTestCase extends TestCase |
There was a problem hiding this comment.
Class extends undeclared class \PHPUnit\Framework\TestCase
| $cnpj = $this->removeMask($cnpj); | ||
|
|
||
| // applying 14 digits | ||
| $cnpj = str_pad($cnpj, 14, '0', STR_PAD_LEFT); |
There was a problem hiding this comment.
Argument 1 (input) is int but \str_pad() takes string
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/Coderockr/orcamentos/pulls/105. |
eminetto
reviewed
Oct 9, 2018
|
|
||
| class ApplicationTestCase extends PHPUnit_Framework_TestCase | ||
| class ApplicationTestCase extends \PHPUnit\Framework\TestCase |
There was a problem hiding this comment.
Class extends undeclared class \PHPUnit\Framework\TestCase
lucassabreu
approved these changes
Oct 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feat references the issue #104 (#104)