Enhance error handling and logging in pr_code_suggestions with defaul…

…t scores and contextualized self_reflection
Codium-ai · May 12, 2024 · d348cff · d348cff
1 parent c04ab93
commit d348cff
Showing 1 changed file with 18 additions and 5 deletions.
diff --git a/pr_agent/tools/pr_code_suggestions.py b/pr_agent/tools/pr_code_suggestions.py
@@ -186,8 +186,20 @@ async def _get_prediction(self, model: str, patches_diff: str) -> dict:
                 code_suggestions_feedback = response_reflect_yaml["code_suggestions"]
                 if len(code_suggestions_feedback) == len(data["code_suggestions"]):
                     for i, suggestion in enumerate(data["code_suggestions"]):
-                        suggestion["score"] = code_suggestions_feedback[i]["suggestion_score"]
-                        suggestion["score_why"] = code_suggestions_feedback[i]["why"]
+                        try:
+                            suggestion["score"] = code_suggestions_feedback[i]["suggestion_score"]
+                            suggestion["score_why"] = code_suggestions_feedback[i]["why"]
+                        except Exception as e: #
+                            get_logger().error(f"Error processing suggestion score {i}",
+                                               artifact={"suggestion": suggestion,
+                                                         "code_suggestions_feedback": code_suggestions_feedback[i]})
+                            suggestion["score"] = 7
+                            suggestion["score_why"] = ""
+            else:
+                get_logger().error(f"Could not self-reflect on suggestions. using default score 7")
+                for i, suggestion in enumerate(data["code_suggestions"]):
+                    suggestion["score"] = 7
+                    suggestion["score_why"] = ""
 
         return data
 
@@ -539,9 +551,10 @@ async def self_reflect_on_suggestions(self, suggestion_list: List, patches_diff:
             system_prompt_reflect = environment.from_string(get_settings().pr_code_suggestions_reflect_prompt.system).render(
                 variables)
             user_prompt_reflect = environment.from_string(get_settings().pr_code_suggestions_reflect_prompt.user).render(variables)
-            response_reflect, finish_reason_reflect = await self.ai_handler.chat_completion(model=model,
-                                                                            system=system_prompt_reflect,
-                                                                            user=user_prompt_reflect)
+            with get_logger().contextualize(command="self_reflect_on_suggestions"):
+                response_reflect, finish_reason_reflect = await self.ai_handler.chat_completion(model=model,
+                                                                                system=system_prompt_reflect,
+                                                                                user=user_prompt_reflect)
         except Exception as e:
             get_logger().info(f"Could not reflect on suggestions, error: {e}")
             return ""