-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable publishing labels by default #1299
Conversation
…elated documentation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
/improve |
@@ -133,7 +133,7 @@ async def run(self): | |||
|
|||
if get_settings().config.publish_output: | |||
# publish labels | |||
if get_settings().pr_description.publish_labels and self.git_provider.is_supported("get_labels"): | |||
if get_settings().pr_description.publish_labels and pr_labels and self.git_provider.is_supported("get_labels"): | |||
original_labels = self.git_provider.get_pr_labels(update=True) | |||
get_logger().debug(f"original labels", artifact=original_labels) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Consider using an f-string for the debug log message to improve readability and consistency. [enhancement, importance: 7]
get_logger().debug(f"original labels", artifact=original_labels) | |
get_logger().debug(f"original labels: {original_labels}") |
@@ -133,7 +133,7 @@ async def run(self): | |||
|
|||
if get_settings().config.publish_output: | |||
# publish labels | |||
if get_settings().pr_description.publish_labels and self.git_provider.is_supported("get_labels"): | |||
if get_settings().pr_description.publish_labels and pr_labels and self.git_provider.is_supported("get_labels"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Consider adding a check for pr_labels
before the conditional statement to avoid potential issues if pr_labels
is None or empty. [possible issue, importance: 5]
User description
…elated documentation
PR Type
documentation, enhancement
Description
pr_description.publish_labels
tofalse
across the codebase and documentation.pr_labels
in the label publishing logic to prevent unnecessary operations.publish_labels
setting according to their preferences.Changes walkthrough 📝
pr_description.py
Add check for `pr_labels` before publishing
pr_agent/tools/pr_description.py
pr_labels
before publishing labels.README.md
Update README with new default label settings
README.md
publish_labels
tofalse
.describe.md
Update `publish_labels` default in documentation
docs/docs/tools/describe.md
publish_labels
.configuration.toml
Set `publish_labels` default to false in config
pr_agent/settings/configuration.toml
publish_labels
tofalse
.