Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml #49

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

moi15moi
Copy link
Contributor

This PR proposes to replace the existing setup.py file with a pyproject.toml file to modernize the project's build system configuration.

Note that I changed a bit the configuration.
Previously, we had this code to configure the requirements:

if os.environ.get("READTHEDOCS") != "True":
    requirements.extend(
        [
            'pywin32; sys_platform == "win32"',
            'pycairo; sys_platform == "linux" or sys_platform == "darwin"',
            'PyGObject; sys_platform == "linux" or sys_platform == "darwin"',
        ]
    )

Now, it will always install those packages. I don't think it is possible to look to a environment variable with a pyproject.toml configuration file.

@moi15moi
Copy link
Contributor Author

The macOS and the lint CI fails is unrelated to this PR.

@CoffeeStraw
Copy link
Owner

Thanks!
I should have fixed CI issues, could you rebase and run them again when you have time?

Also, could you remove the < Python3.9 tags and add 3.11 and 3.12?

@moi15moi moi15moi force-pushed the Switch-to-pyproject branch 2 times, most recently from 594d325 to 19f15b9 Compare August 3, 2024 14:59
@moi15moi
Copy link
Contributor Author

moi15moi commented Aug 3, 2024

Done

pyproject.toml Show resolved Hide resolved
setup.py Show resolved Hide resolved
@CoffeeStraw CoffeeStraw merged commit ad175fa into CoffeeStraw:master Aug 6, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants