fix: check custom attributes when reading info

Changed flag to skipCustomAttributeChecks and made it true by default
since we should only be checking this from InfoImporter, we should be
ignoring for jvm bundles for example. Also added back the
skipASMValidation check to make sure parity is the same

recaf-core/src/main/java/software/coley/recaf/info/builder/JvmClassInfoBuilder.java

@@ -24,7 +24,7 @@
 public class JvmClassInfoBuilder extends AbstractClassInfoBuilder<JvmClassInfoBuilder> {
 	private byte[] bytecode;
 	private int version = JvmClassInfo.BASE_VERSION + 8; // Java 8
-	private boolean skipASMValidation;
+	private boolean skipCustomAttributeChecks = true;
 	@Nullable
 	private ClassBuilderAppender classVisitor;
 
@@ -90,7 +90,6 @@ public JvmClassInfoBuilder adaptFrom(@Nonnull ClassReader reader) {
 	 * 		Reader flags to use when populating information.
 	 *
 	 * @return Builder.
-	 * @throws IllegalStateException if using asm validation and the class has custom attributes
 	 */
 	@Nonnull
 	@SuppressWarnings(value = "deprecation")
@@ -112,9 +111,15 @@ public JvmClassInfoBuilder withVersion(int version) {
 		return this;
 	}
 
+	/**
+	 * The default value is true. When {@code verify} is run it will check if there are any custom attributes.
+	 *
+	 * @param skipCustomAttributeChecks {@code false} if we want to verify the classes custom attribute
+	 * @return {@code JvmClassInfoBuilder}
+	 */
 	@Nonnull
-	public JvmClassInfoBuilder skipASMValidation(boolean skipASMValidation) {
-		this.skipASMValidation = skipASMValidation;
+	public JvmClassInfoBuilder skipCustomAttributeChecks(boolean skipCustomAttributeChecks) {
+		this.skipCustomAttributeChecks = skipCustomAttributeChecks;
 		return this;
 	}
 
@@ -139,7 +144,7 @@ protected void verify() {
 			throw new IllegalStateException("Bytecode required");
 		if (version < JvmClassInfo.BASE_VERSION)
 			throw new IllegalStateException("Version cannot be lower than 44 (v1)");
-		if (!this.skipASMValidation && classVisitor != null && classVisitor.hasCustomAttributes()) {
+		if (!this.skipCustomAttributeChecks && classVisitor != null && classVisitor.hasCustomAttributes()) {
 			throw new IllegalStateException("Unknown attributes found in class: " + this.getName() + "[" +
 				String.join(", ", classVisitor.getCustomAttributeNames()) + "]");
 		}

recaf-core/src/main/java/software/coley/recaf/workspace/io/BasicInfoImporter.java

@@ -3,8 +3,6 @@
 import jakarta.annotation.Nonnull;
 import jakarta.enterprise.context.ApplicationScoped;
 import jakarta.inject.Inject;
-import org.objectweb.asm.ClassReader;
-import org.objectweb.asm.ClassWriter;
 import org.slf4j.Logger;
 import software.coley.cafedude.classfile.VersionConstants;
 import software.coley.recaf.analytics.logging.Logging;
@@ -43,17 +41,21 @@ public Info readInfo(@Nonnull String name, @Nonnull ByteSource source) throws IO
 		// Check for Java classes
 		if (matchesClass(data)) {
 			try {
+				if (config.doSkipAsmValidation()) {
+					return new JvmClassInfoBuilder(data).build();
+				}
+
 				try {
 					return new JvmClassInfoBuilder(data)
-						.skipASMValidation(config.doSkipAsmValidation())
+						.skipCustomAttributeChecks(false)
 						.build();
 				} catch (Throwable t) {
 					// Patch if not compatible with ASM
 					byte[] patched = classPatcher.patch(name, data);
 					logger.debug("CafeDude patched class: {}", name);
 					try {
 						return new JvmClassInfoBuilder(patched)
-							.skipASMValidation(config.doSkipAsmValidation())
+							.skipCustomAttributeChecks(false)
 							.build();
 					} catch (Throwable t1) {
 						logger.error("CafeDude patching output is still non-compliant with ASM for file: {}", name);