Add warning about kotlin metadata ordering

Col-E · Jan 11, 2025 · ac39522 · ac39522
1 parent b8b9d73
commit ac39522
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/recaf-ui/src/main/java/software/coley/recaf/ui/pane/editing/tabs/KotlinMetadataPane.java b/recaf-ui/src/main/java/software/coley/recaf/ui/pane/editing/tabs/KotlinMetadataPane.java
@@ -6,18 +6,24 @@
 import jakarta.annotation.Nullable;
 import jakarta.enterprise.context.Dependent;
 import jakarta.inject.Inject;
+import javafx.geometry.Insets;
+import javafx.geometry.Pos;
+import javafx.scene.control.Label;
 import javafx.scene.control.TreeCell;
 import javafx.scene.control.TreeItem;
 import javafx.scene.control.TreeView;
 import javafx.scene.layout.BorderPane;
+import javafx.scene.layout.StackPane;
 import software.coley.recaf.info.ClassInfo;
 import software.coley.recaf.path.ClassPathNode;
 import software.coley.recaf.path.PathNode;
 import software.coley.recaf.services.navigation.Actions;
 import software.coley.recaf.services.navigation.Navigable;
 import software.coley.recaf.services.text.TextFormatConfig;
 import software.coley.recaf.ui.config.MemberDisplayFormatConfig;
+import software.coley.recaf.ui.control.BoundLabel;
 import software.coley.recaf.util.Icons;
+import software.coley.recaf.util.Lang;
 import software.coley.recaf.util.kotlin.model.KtClass;
 import software.coley.recaf.util.kotlin.model.KtConstructor;
 import software.coley.recaf.util.kotlin.model.KtElement;
@@ -83,7 +89,14 @@ protected void updateItem(KtElement element, boolean empty) {
 				}
 			}
 		});
+		Label label = new BoundLabel(Lang.getBinding("kotlinmetadata.orderwarning"));
+		label.getStyleClass().add(Styles.TEXT_SUBTLE);
+		label.setPadding(new Insets(8));
+		label.setWrapText(true);
+		BorderPane labelWrapper = new BorderPane(label);
+		labelWrapper.getStyleClass().add("workspace-filter-pane"); // Style used for top-border separator
 		setCenter(tree);
+		setBottom(labelWrapper);
 		setMinWidth(235);
 	}
 

diff --git a/recaf-ui/src/main/resources/translations/en_US.lang b/recaf-ui/src/main/resources/translations/en_US.lang
@@ -386,6 +386,7 @@ hierarchy.parents=Parents
 
 ## Kotlin Metadata
 kotlinmetadata.title=@Metadata
+kotlinmetadata.orderwarning=Important: Items do not appear in the same order as defined in the class file
 
 ## Logging
 logging.title=Logging