Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK 22 migraiton #775

Merged
merged 6 commits into from
Apr 27, 2024
Merged

JDK 22 migraiton #775

merged 6 commits into from
Apr 27, 2024

Conversation

xxDark
Copy link
Collaborator

@xxDark xxDark commented Apr 11, 2024

What's new

Migrate to JDK 22. Blocked on Col-E/LL-Java-Zip#28

Pros:

  • Newest API
  • Can upgrade JavaFX

Cons:

  • Not LTS
  • Will probably have to do something about these nasty warns in ReflectUtil at some point..
  • Some people would cry

@xxDark xxDark added Discussion dependencies Pull requests that update a dependency file 4.X labels Apr 11, 2024
@Col-E
Copy link
Owner

Col-E commented Apr 19, 2024

gradle complaining

gradle rel notes

uhhhh.... what?

You cannot run Gradle 8.7 itself with Java 22 because Groovy still needs to support JDK 22. However, future versions are expected to provide this support.

😐

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 70.34%. Comparing base (89c5920) to head (0d632a8).
Report is 20 commits behind head on dev4.

❗ Current head 0d632a8 differs from pull request most recent head 4a6cc16. Consider uploading reports for the commit 4a6cc16 to get more accurate results

Files Patch % Lines
...tware/coley/recaf/info/member/FieldMemberTest.java 0.00% 4 Missing and 4 partials ⚠️
...are/coley/recaf/util/io/LocalFileHeaderSource.java 25.00% 4 Missing and 2 partials ⚠️
...rc/main/java/software/coley/recaf/util/IOUtil.java 25.00% 3 Missing ⚠️
...java/software/coley/recaf/util/io/ByteSources.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               dev4     #775      +/-   ##
============================================
+ Coverage     70.32%   70.34%   +0.02%     
- Complexity     2951     2988      +37     
============================================
  Files           346      347       +1     
  Lines         15392    15586     +194     
  Branches       1736     1771      +35     
============================================
+ Hits          10824    10964     +140     
- Misses         3728     3767      +39     
- Partials        840      855      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Unit test results

 54 files  + 2   54 suites  +2   23s ⏱️ +2s
374 tests +12  368 ✅ +12  6 💤 ±0  0 ❌ ±0 
396 runs  +34  390 ✅ +34  6 💤 ±0  0 ❌ ±0 

Results for commit 0d632a8. ± Comparison against base commit 89c5920.

Col-E added 2 commits April 27, 2024 00:23
…Mostly useful for not killing workspace reading when looking at embedded files.
@Col-E Col-E merged commit c9fa994 into dev4 Apr 27, 2024
1 check passed
@Col-E Col-E deleted the jdk22 branch June 6, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.X dependencies Pull requests that update a dependency file Discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants