feat: detect lookup switch labels in search results #812
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Col-E
reviewed
Jun 25, 2024
recaf-core/src/main/java/software/coley/recaf/util/BlwUtil.java
Outdated
Show resolved
Hide resolved
- SimpleInstruction are displayed as 'Xswitch' in result view (better than nothing)
Jydett
force-pushed
the
feature/allow_search_switch_labels
branch
from
e007135 to
2e7db3c
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Allow the search to match switch labels, and allow the result to be displayed in the result panel as 'lookupswitch'.
In my usecase, I have a huge codebase with a lot of 'switch' but I can't search for their labels in Recaf 4.X (they are number):
Results:
Without the edit in BlwUtil, the instruction is passed to ``execute(Instruction instruction)` and thus nothing is displayed.