Fix EnigmaMappings parsing #903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s no newline/space at the end
…mprove # Conflicts: # recaf-core/src/test/java/software/coley/recaf/services/mapping/format/MappingImplementationTest.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #903 +/- ##
============================================
- Coverage 64.68% 64.66% -0.03%
- Complexity 3121 3141 +20
============================================
Files 375 375
Lines 15736 15803 +67
Branches 2228 2244 +16
============================================
+ Hits 10179 10219 +40
- Misses 4520 4531 +11
- Partials 1037 1053 +16 ☔ View full report in Codecov by Sentry. |
|
Had some local changes which confused github, but this is merged now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
-as no mappingACC:xxxaccess modifierWhat's fixed
The parser now only supports tab indents (as per enigma mappings specification) , no longer other characters trim is removing (ascii code points < 19 no longer regarded as tab.