Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ 피드 숨기기, 숨기기 취소 모킹 API Handler 추가 및 type 정리 #17

Merged
merged 12 commits into from
Nov 20, 2024

Conversation

suhwan2004
Copy link
Collaborator

@suhwan2004 suhwan2004 commented Nov 17, 2024

CheckList

  • gap를 이용하여 flex 컨테이너 내 자식 요소간의 간격을 제어하였나요? (iOS 14 미지원으로 gap -> space-x, space-y 적용)

작업 이유

  1. 피드 숨기기, 숨기기 취소 모킹 API Handlers 작업 진행
  2. mock 위주로 타입 보강이 필요한 부분 작업 진행

작업 사항

1️⃣ 피드 숨기기, 숨기기 취소 모킹 API Handlers 작업 진행

피드 숨기기, 숨기기 취소 기능에 필요한 모킹 API Handlers를 작업했습니다.
handler에 적용되는 type이 있는 model 폴더의 생성 위치는 hide를 새로 만들어서 두었습니다.

2️⃣ mock 위주로 타입 보강이 필요한 부분 작업 진행

이번에 작업 진행을 하다보니 handlers 코드를 보다가 타입을 넣을 수 있는 부분이 있겠다 생각하여, 추가적으로 타입 보강 작업을 진행하게 되었습니다!

리뷰어가 중점적으로 확인해야 하는 부분

  • 모킹 API Handlers 로직에 특이사항이 있는지
  • 생성 및 보강된 타입 관련하여 특이사항이 있는지

발견한 이슈

X

@suhwan2004 suhwan2004 self-assigned this Nov 17, 2024
Copy link

github-actions bot commented Nov 17, 2024

🔍 Visual review for your branch is published 🔍

Here are the links to:

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-17.d1rrzjx2upcmxq.amplifyapp.com

Copy link
Collaborator

@BangDori BangDori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 확인 부탁드립니다아~

src/entities/search/model/search.type.ts Outdated Show resolved Hide resolved
src/entities/search/model/search.type.ts Outdated Show resolved Hide resolved
src/entities/feed/model/write.type.ts Outdated Show resolved Hide resolved
src/entities/feed/model/report.type.ts Show resolved Hide resolved
src/app/mocks/handlers/hide.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@BangDori BangDori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~!

Copy link
Member

@Legitgoons Legitgoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

병준님이 자세하게 봐주셔서 크게 comment 할 게 없네용 ㅎㅎ;;
간단한 질문 하나 남겼고, approve 하겠습니다!

src/app/mocks/handlers/feed.ts Show resolved Hide resolved
@suhwan2004 suhwan2004 merged commit 2a6f7d3 into main Nov 20, 2024
2 checks passed
@suhwan2004 suhwan2004 deleted the feat/msw-feed-regist-handler branch November 20, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants