⚙️ pre-push 세팅 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
suhwan2004
force-pushed
the
feat/pre-push-setting
branch
from
d1812be
to
8306048
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
push
해당 PR 에서 병준님이 말씀주신 대로, 실수로 main 브랜치에서 작업 후 push를 하는 경우를 막기 위해 husky를 활용한 pre-push를 세팅하였습니다.
작업 사항
1️⃣ pre-push 추가
.husky > pre-push 파일을 추가하였습니다. 동작의 경우, 둘 다 메인이라고 가정한다면
=> 터미널 내에 "🐶 Do not push to the main Branch" 메시지로 경고와 함께, push가 멈춥니다. (물론, pre-push가 없어도 레포 룰로 인해 main push가 막히나, 리모트에 닿기 전에 push를 막는 것에 의의가 있는 것으로...)
2.원류 레포를 본 따 만든 fork repository일 시
=> 따로 main 브랜치 push의 제한을 두지 않았습니다. fork의 main 브랜치를 push할 경우가 있지 않다고 생각했습니다.
리뷰어가 중점적으로 확인해야 하는 부분
발견한 이슈
X