calc: update viewedRectangle on status message #10651
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please solve conflict and rebase to pass CI :) |
JaumePujantell
force-pushed
the
private/jaume/calc-viewedrectangle
branch
from
ab860f8 to
829999f
Compare
|
cypress tests were updated :( |
JaumePujantell
force-pushed
the
private/jaume/calc-viewedrectangle
branch
2 times, most recently
from
ce49505 to
1286ea3
Compare
|
hi @JaumePujantell , is that ready to review now? |
eszkadev
reviewed
Jan 9, 2025
|
Please rebase as I updated some related code and tests recently |
viewedRectangle was not properly being updated when new document sizes were received via status message. This sometimes caused the view to not scroll properly when using arrow keys to select cells just after opening a file. Tried to add a cypress test but couldn't get the error to trigger on cypress. Some test have been updated due to changed scrollbar sizes, since the bar size depends on the document size. This change also broke 'Jump on search with not visible cursor' test. Fixed by ensuring the cursor is followed on search. Signed-off-by: Jaume Pujantell <[email protected]> Change-Id: I48058b0ac5df70ca14a0a7c32e1f9b697fa37f81
eszkadev
force-pushed
the
private/jaume/calc-viewedrectangle
branch
from
1286ea3 to
b5a51a5
Compare
|
I rebased |
|
I moved rebased commit to other PR with related fixes: #10881 @JaumePujantell thanks I tested and see it works when we scroll to pos which wasn't visible -> full cell in cals is now visible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
viewedRectangle was not properly being updated when new document sizes
were received via status message. This sometimes caused the view to not
scroll properly when using arrow keys to select cells just after opening
a file.
Some test have been updated due to changed scrollbar sizes, since the
bar size depends on the document size.
Tried to add a cypress test but couldn't get the error to trigger on
cypress.
Signed-off-by: Jaume Pujantell [email protected]
Change-Id: I48058b0ac5df70ca14a0a7c32e1f9b697fa37f81