sc: remove context-menu-layer for autofill context-menu

[bayramcicek]

• generate a left mouse click so that a single click can select a cell after closing the autofill context menu.
• we avoid the second click to select a cell after autofill context menu is opened.
• this only applies to the autofill context-menu. other context menus should not be affected.

Change-Id: Iaf7b5c09003291f27155ae9ab6787f2f871ac466

• Resolves: #
• Target version: master

Checklist

• I have run make prettier-write and formatted the code.
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[bayramcicek]

• this fixes the double click issue on autofill contextmenu. but prevents the contextmenu from closing itself when scrolling and opening another popups...

• a working example:

Peek.2024-12-20.14-45.mp4

[eszkadev]

is it finished? or still draft/wip ?

[bayramcicek]

is it finished? or still draft/wip ?

still WIP. I'm trying to fix some issues.

[bayramcicek]

before: (master)

Peek.2025-01-03.12-55-master.mp4

after:

Peek.2025-01-03.12-58-after.mp4

[eszkadev]

hmm, isn't the autofill menu generated in online?
or do we pass it from core? (I don't remember)

[bayramcicek]

autofill contextmenu is generated in online. (only items in the context menu send UNO command to the core.)

[eszkadev]

but does it take any data from core to create that popup?
if NOT use core at all to invoke popup -> this approach is possibly wrong -> why we would need to do additional click in core while popup was online only? or I missed something?

[bayramcicek]

but does it take any data from core to create that popup? if NOT use core at all to invoke popup -> this approach is possibly wrong -> why we would need to do additional click in core while popup was online only? or I missed something?

yes, that's right. Is there any way to do additional click on the online? I thought _postMouseEvent is on the online.

[eszkadev]

Then - adding a click feels like workaround. It would be good to be able to answer: why we need additional click?

Do we have present .jsdialog-overlay on the screen maybe? Or the map/canvas is not in focus?
Do you have some logs from the browser - what happens just after the first click?

[bayramcicek]

Then - adding a click feels like workaround.

• yes. we can say that it is a workaround.

It would be good to be able to answer: why we need additional click?

• after opening the autofill contexmenu there is a id="context-menu-layer" that blocks scroll and clicking on the cells.
• if we click on a cell -to select it-, it does not click the cell but removes the layer. So if we add an additional click at this point, then we can click on the cell we are on - after that layer was removed - without need to double click.

Do we have present .jsdialog-overlay on the screen maybe?

• we have id="context-menu-layer"

Or the map/canvas is not in focus?
gets focus after contextmenu is hidden.

Control.ContextMenu.js:219

					hide: function() {
						if(autoFillContextMenu)
							app.map._docLayer._resetReferencesMarks();
						map.focus();
					}

Do you have some logs from the browser - what happens just after the first click?

hide: function() ^^^ executes and id="context-menu-layer" is removed. then auto contextmenu is closed.

[eszkadev]

I see. what about something like:

diff --git a/browser/src/control/Control.ContextMenu.js b/browser/src/control/Control.ContextMenu.js
index aecb8a6fe7..c7a13d264c 100644
--- a/browser/src/control/Control.ContextMenu.js
+++ b/browser/src/control/Control.ContextMenu.js
@@ -204,9 +204,22 @@ L.Control.ContextMenu = L.Control.extend({
                                                var $menu = opt.$menu;
                                                $menu.attr('tabindex', 0); // Make the context menu focusable
                                        },
+                                       activated: function (opt) {
+                                               console.error('activated');
+                                               console.error(opt);
+
+                                               var $layer = opt.$layer;
+                                               $layer.css('pointer-events', 'none'); // layer doesn't get mouse clicks
+
+                                               $layer.on('mousedown', function () {
+                                                       console.error('This click handler will not be fired');
+                                               });
+                                       },
                                        hide: function() {
-                                               if(autoFillContextMenu)
+                                               if(autoFillContextMenu) {
                                                        app.map._docLayer._resetReferencesMarks();
+                                                       console.error('but this will be still fired thanks to entry in context menu');
+                                               }
                                                map.focus();

activated event is called when context menu is built and ready to use.
We can just remove the layer on show but.. perfect would be to just not handle clicks to avoid errors inside jQuery.

you can read also internals of jQuery: browser/node_modules/jquery-contextmenu/src/jquery.contextMenu.js for interesting details

[eszkadev]

did you test that with multiple users?
A: open autofill
B: tries to click to move cursor somewhere

does the autofil from A view have impact on B?

[bayramcicek]

did you test that with multiple users? A: open autofill B: tries to click to move cursor somewhere

does the autofil from A view have impact on B?

my experience with multiple users seem work as expected. (or should it behave different?)

Peek.2025-01-03.15-26.mp4