Fix toggle status of show all comments button #10803
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before initial state was always true. Now we decide to initial state according to document have comments or not. If document have comments, default initial state is comments on, if not comments off. Signed-off-by: Gülşah Köse <[email protected]> Change-Id: If3e8eb5eeff29c8a72658d0afafc7379444d62ab
eszkadev
reviewed
Dec 26, 2024
| var show = this.map.stateChangeHandler.getItemValue('showannotations'); | ||
| this.setView(show === true || show === 'true'); | ||
| var initalShowAnnotations = commentList.length > 0; | ||
| app.map.showComments(initalShowAnnotations); |
There was a problem hiding this comment.
This makes it out of sync when inserting a comment to document which didn't have comments before.
Then you have to click 2 times "show comments" to acctually toggle.
I think it should stay as it was (default is on) - less problems.
As improvement we can probably remember the last state which user had in the local browser settings? cc: @pedropintosilva
Or maybe it is saved in the document? Could you try with odt and docx, if they remember the last status after we save and reopen document in LibreOffice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before initial state was always true.
Now we decide to initial state according to document have comments or not. If document have comments, default initial state is comments on, if not comments off.
Change-Id: If3e8eb5eeff29c8a72658d0afafc7379444d62ab
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay