wsd: suppress Ctrl+q #10817
Merged
wsd: suppress Ctrl+q #10817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ctrl+q shortcut exits Core when forwarded. There is no use to having this shortcut processed in Core, so we suppress it. If we should process it by saving and closing the document, it needs to be handled in a special way (ideally by sending 'closedocument' from the client instead). Change-Id: I6b3280342490a013645ae73888188f20cd25168d Signed-off-by: Ashod Nakashian <[email protected]>
caolanm
approved these changes
Jan 6, 2025
|
Really we should kill uno:Quit in the core rather than around the edge like this - no doubt some other creative person will find a way to invoke it and loose their changes some other way otherwise ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ctrl+q shortcut exits Core when
forwarded. There is no use to having
this shortcut processed in Core, so
we suppress it.
If we should process it by saving and
closing the document, it needs to be
handled in a special way (ideally by
sending 'closedocument' from the
client instead).
Change-Id: I6b3280342490a013645ae73888188f20cd25168d
Signed-off-by: Ashod Nakashian [email protected]