Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Improvements (1) #10848

Merged
merged 12 commits into from
Jan 6, 2025
Merged

Misc Improvements (1) #10848

merged 12 commits into from
Jan 6, 2025

Conversation

Ashod
Copy link
Contributor

@Ashod Ashod commented Jan 3, 2025

  • wsd: log the name of errno rather than its number
  • wsd: better logging
  • wsd: avoid copying parameters
  • wsd: allow moving Callback instances
  • wsd: avoid copying shared_ptr parameter
  • wsd: cosmetic const and documentation
  • wsd: remove unused types
  • wsd: avoid parameter copying
  • wsd: sort default configs for friendliness
  • wsd: formatting and documentation
  • wsd: avoid copying literal strings
  • readme: update dependency documentation

@Ashod Ashod changed the title private/ash/misc Misc Improvements Jan 3, 2025
@Ashod Ashod requested a review from caolanm January 3, 2025 02:52
@Ashod Ashod changed the title Misc Improvements Misc Improvements (1) Jan 6, 2025
Ashod added 12 commits January 5, 2025 21:12
More user-friendly to read a name rather than
a number that needs to be looked up.

Change-Id: I3a758dbd4667d96b060bd84076dd2a7ee8fa581c
Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I967487e95216e1fa2308563816126723a243471c
Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I340095a542a61ac6afe868ca15b4e135d3f64fbc
Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I53a87a5ec7e1c5f49cfdad82d22e443628f272f1
Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: Ie18252f6415888dcf72cd7de5cfd89f229180f90
Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I5b0a067e665a84a7386188c225da60f1d8af4644
Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I8a7f0699e85b092636e95f709f0a7970c7c1a008
Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: Iacbb2641f0d4e263e0cd83b4b67f40022763105c
Signed-off-by: Ashod Nakashian <[email protected]>
For settings that have "name" properties,
it's more readable to have the property
before the value, even though lexicographically
that's not the right order. This avoids
confusing the reader by thinking the next
line is the value of the of the property
name just read on the previous line,
which is what lexicographical sorting
produces.

Change-Id: I85752c9d06053a5e62217fc27e96e1ebf50ecdfb
Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I49ffd41bc526cbca5660bce958232464382b7958
Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I536e58822c486132609affa5d4bb7a088c9201f8
Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I6936b6a90bbcc7cf8f3e3ea018c92f79f39714b0
Signed-off-by: Ashod Nakashian <[email protected]>
@Ashod Ashod force-pushed the private/ash/misc branch from 85d23bf to c95fd1b Compare January 6, 2025 02:12
// NOTE: This is sorted, please keep it sorted as it's friendlier to readers.
// NOTE: This is sorted, please keep it sorted as it's friendlier to readers,
// except for properties, which are sorted before the value, e.g.
// "setting[@name]" before "setting", which is more readable.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent :-)

@caolanm caolanm merged commit c98a8cd into master Jan 6, 2025
14 checks passed
@caolanm caolanm deleted the private/ash/misc branch January 6, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants