Misc Improvements (2) #10855
Merged
Misc Improvements (2) #10855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ashod
commented
Jan 6, 2025
Ashod
commented
- wsd: cosmetics
- wsd: use non-deprecated SSL_get1_peer_certificate
- wsd: string -> string_view
- wsd: include cleanup
- wsd: log the OpenSSL version
- wsd: as of C++17 [[fallthrough]] is standard
- wsd: constexpr string_view
Change-Id: Ib1c72b73e892f2416c2493e4bf03736e07a459d1 Signed-off-by: Ashod Nakashian <[email protected]>
SSL_get1_peer_certificate doesn't auto-release the x509 instance, and lets us handle the lifetime, which is what we need. The now-deprecated SSL_get_peer_certificate was already mapped to SSL_get1_peer_certificate. Change-Id: Ic57586d114ec66bedb48005eb8cdf304565d8a6a Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: Ic6c0621d009c18a6789527add65c2fd2ebb701d9 Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I97cda4267af25791fa54e18c05958a7c131f15c0 Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: Ibd5eb673b81db4aa56439c6463ccae61e7c8cf6a Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I16f4639feb6978f847a762a88a4de579db5476b3 Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I9b333b4e9588c418e7160b843dfcd10b5542198f Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: Ia9a7a6a856b09d8679fa46ee2dd3dde685baad75 Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: Ia10ae28a0cf9f4e5c5345dbc60da71a341d63e26 Signed-off-by: Ashod Nakashian <[email protected]>
caolanm
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.