Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsdialog: treeview improvements #10870

Merged
merged 3 commits into from
Jan 8, 2025
Merged

jsdialog: treeview improvements #10870

merged 3 commits into from
Jan 8, 2025

Conversation

eszkadev
Copy link
Contributor

@eszkadev eszkadev commented Jan 8, 2025 •
edited
Loading

@eszkadev
jsdialog: create cells in separate function
b868496 
no functional change

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I1f1b004272d60f9f3a32fa2b5e8055e180fd4736
@eszkadev
jsdialog: move sorting to separate function
36cdd93 
no functional change

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I79f1b7714130b9d632f4fed32815e5245e6afe2e
@eszkadev eszkadev force-pushed the private/eszkadev/jsdialog-treeview branch from 8da4259 to 98731fa Compare January 8, 2025 11:09
@eszkadev eszkadev added the draft label Jan 8, 2025
@eszkadev
jsdialog: add sortable property support to treeveiew
dd00f1e 
it allows to block sorting if it is not needed
eg. in Help -> Server Audit dialog

follow the standard naming for TreeWidgetJSON

Signed-off-by: Szymon Kłos <[email protected]>
Change-Id: I89bfa247cd5a759d768ba73125f1f2bcee755d5e
@eszkadev eszkadev force-pushed the private/eszkadev/jsdialog-treeview branch from 98731fa to dd00f1e Compare January 8, 2025 11:14
@eszkadev eszkadev marked this pull request as ready for review January 8, 2025 11:59
@eszkadev eszkadev requested a review from gokaysatir January 8, 2025 11:59
gokaysatir
gokaysatir approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@gokaysatir gokaysatir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements :)

@eszkadev eszkadev merged commit f610b1e into master Jan 8, 2025
14 checks passed
@eszkadev eszkadev deleted the private/eszkadev/jsdialog-treeview branch January 8, 2025 20:30
@eszkadev
Copy link
Contributor Author

eszkadev commented Jan 9, 2025

related to #10841

@banobepascal banobepascal mentioned this pull request Jan 14, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gokaysatir gokaysatir gokaysatir approved these changes

Assignees
No one assigned
Labels
draft
Projects
Collabora Online
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eszkadev @gokaysatir