Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct text and icon alignments in server audit dialog #10925

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Correct text and icon alignments in server audit dialog #10925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion browser/css/jsdialogs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,12 @@ td.jsdialog > [id^='table-box']:not(.sidebar) {
white-space: nowrap;
}

#ServerAuditDialog .ui-treeview-entry {
pedropintosilva marked this conversation as resolved.
Show resolved Hide resolved
display: grid;
grid-template-columns: var(--btn-img-size-m) 6fr 3fr;
white-space: normal;
}

.ui-treeview-expanded-content {
display: grid;
}
Expand Down Expand Up @@ -568,6 +574,21 @@ td.jsdialog > [id^='table-box']:not(.sidebar) {
/* grid-column: '1 / ' + (this._columns + 1) - set inside JS */
}

#ServerAuditDialog .ui-treeview-headers {
pedropintosilva marked this conversation as resolved.
Show resolved Hide resolved
display: grid;
grid-column-end: 4 !important;
grid-template-columns: 0fr 6fr 3fr;
margin-inline-start: 4px;
}

#ServerAuditDialog .ui-treeview-headers div.ui-treeview-icon-column {
width: 0px /* prevent display of ui-treeview-icon-column in ui-treeview-header */
}

#ServerAuditDialog .ui-treeview-headers > div:nth-last-child(1) {
margin-inline-start: 7px;
}
Comment on lines +588 to +590
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to don't added this margin. I would prefer to add the inherited margin from the entries only when there is a single column, rather than applying the margin here to align with the entries. But let's merge this for now and we cna discuss this later.


.ui-treeview-header {
display: inline-block;
width: 100%;
Expand Down Expand Up @@ -2209,11 +2230,12 @@ kbd,
}

#ServerAuditDialog #ServerAuditDialog-mainbox {
min-width: calc(min(800px, 80vw));
min-width: calc(min(600px, 80vw));
}

#ServerAuditDialog .ui-treeview {
border-color: transparent;
max-height: max-content;
}
#ServerAuditDialog .ui-treeview td[role='gridcell'] {
padding-inline-start: 0;
Expand Down
Loading