browser: notify user for unsupported video #7222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashod
reviewed
Sep 7, 2023
lpranam
force-pushed
the
unsupported_video_notification
branch
from
88edb49 to
cd37b92
Compare
lpranam
force-pushed
the
unsupported_video_notification
branch
from
cd37b92 to
fadaec7
Compare
lpranam
force-pushed
the
unsupported_video_notification
branch
2 times, most recently
from
e20bf8c to
612c6f4
Compare
eszkadev
reviewed
Oct 11, 2023
lpranam
force-pushed
the
unsupported_video_notification
branch
2 times, most recently
from
055fca1 to
762798d
Compare
|
doesn't work: when I select video it shows snackbar with information that it is unsupported (but video can be played in my browser): |
lpranam
force-pushed
the
unsupported_video_notification
branch
from
762798d to
c039832
Compare
|
NOTE: This patch does not show a warning in the slideshow as the snake bar can not be displayed over the fullscreen element. will talk to @pedropintosilva about it and fix it in the follow-up. |
eszkadev
approved these changes
Oct 11, 2023
|
I think we can remove slideshow handler here? as it will not work, we need to code "alert" in presentation_engine.js generated by LibreOffice |
detect if video is able to play via checking if any frames are decoded, in other cases(i.e: file not found or corrupted file) check for the errors in source and video Signed-off-by: Pranam Lashkari <[email protected]> Change-Id: I22bfc836a98ec0eb2caa58b89332b2531d69d18f
lpranam
force-pushed
the
unsupported_video_notification
branch
from
c039832 to
13d7f01
Compare
|
I cherry-picked, resolved the conflict, and pushed to master directly. I could not figure out how to push here. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detect if video is being played by browser using fps, if fps is near zero that means video is not able to play
Change-Id: I22bfc836a98ec0eb2caa58b89332b2531d69d18f
Checklist
make checkmake runand manually verified that everything looks okay