Calc: Don't switch tabs when context menu is triggered

[bayramcicek]

• Trying to open context menu from a sheet tab, also changes the active tab. This occurs when right click on a sheet tab (or long tap on mobile or tablet)

• moveLeft and moveRight of inactive tabs are implemented.

• added _moveSheetLR and _moveOrCopySheet functions.

Change-Id: I5b25a8cb363b8e04fd6dcec1f500e7ff2982b678

• Resolves: Calc: sheet tab: triggering context menu switches tabs #7354
• Target version: master

Summary

TODO

Checklist

• Code is properly formatted
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[eszkadev]

it was introduced previously because if we right-clicked on non-selected sheet to open context menu - actions were applied to the selected sheet. It still happens for some actions:
"move sheet left", "move sheet right", "move or copy sheet"

steps to reproduce:

• have 3 sheets, 1st is scurrently selected
• right click on 3rd sheet and do "move sheet left"
  result: sheet 1 is moved
  expected: sheet 3 is moved

[bayramcicek]

it was introduced previously because if we right-clicked on non-selected sheet to open context menu - actions were applied to the selected sheet. It still happens for some actions: "move sheet left", "move sheet right", "move or copy sheet"

steps to reproduce:

• have 3 sheets, 1st is scurrently selected
• right click on 3rd sheet and do "move sheet left"
  result: sheet 1 is moved
  expected: sheet 3 is moved

@eszkadev : I see that https://github.com/CollaboraOnline/online/pull/7377/files#diff-a3b5fb6d0c66140a66a5e27fed984875e9c8f1194a8dfb152a5716b17fc2ea6dL282 _moveSheet only moves the selected sheet to new index with sendUnoCommand('.uno:Move?Copy:bool=false&UseCurrentDocument:bool=true&Index=' + newIndex);

There should be a way to move inactive sheets. I'm not sure but it seems there should be some hack on the core side to make this happen, I wonder what do you think about that?

Thanks for the review.

[bayramcicek]

upstream: 158078: (WIP) sc: make inactive sheets movable/copyable | https://gerrit.libreoffice.org/c/core/+/158078

[eszkadev]

please rebase so Unit & Cypers will pass

[bayramcicek]

fail:

• calc/sheet_operation_spec.js
  • Sheet Operations. Move sheet left/right)
• most of the writer tests failed

• Since we changed the behavior of the sheet tabs and upstream patch is not merged, I think, the fail in the Calc is expected(?).
• and test for the Sheet Operations (sheet_operation_spec.js) should be rewritten/updated since it assumes that right click on a sheet tab will change tab page.

@eszkadev : what should be the next step. ?

I think:

• update sheet_operation_spec.js test to adapt the new sheet tab behavior.
• merge the upstream patch (https://gerrit.libreoffice.org/c/core/+/158078)
• rebase the online to see if CI passes

should I update the sheet_operation_spec.js test?

[eszkadev]

should I update the sheet_operation_spec.js test?

If we will merge core part first, then this PR will pass right?
So we will wait for core.

[bayramcicek]

FYI: I encountered an issue with selecting sheet tabs while testing the patch (it selects the previous/next tab, then selects the correct tab). I'm working on that too. (this is no needed)

[bayramcicek]

upstream: 158078: sc: make inactive sheets movable and copyable | https://gerrit.libreoffice.org/c/core/+/158078
CI is green. Ready for review.

[pedropintosilva]

/me Pulls gerrit change ... sorry

---

Thanks @bayramcicek I have tested all the actions in the context menu. There don't work as expected:

• Move sheet left
• Move sheet right
• Move or copy sheet...

1. If you have: [sheet1] [sheet2] [sheet3] [sheet4] [sheet5] current sheet in bold
2. Right Click in the [sheet4]
3. Choose any of the actions listed above
4. Notice: the actions affect the current sheet instead of the one that was clicked on

[pedropintosilva]

requires: https://gerrit.libreoffice.org/c/core/+/158078

Works awesomely, thanks @bayramcicek !

[pedropintosilva]

Would like to have +2 from @gokaysatir

[gokaysatir]

Thanks @bayramcicek :)

[gokaysatir]

I tested and found no issues. I think we can merge this.