feat: 닉네임 변경 요청 바디 변경 및 유효성 체크

Collusic · May 26, 2024 · f380fb5 · f380fb5
1 parent 504a0a0
commit f380fb5
Show file tree

Hide file tree

Showing 8 changed files with 37 additions and 12 deletions.
diff --git a/src/main/java/com/climingo/climingoApi/global/auth/LoginMemberArgumentResolver.java b/src/main/java/com/climingo/climingoApi/global/auth/LoginMemberArgumentResolver.java
@@ -44,14 +44,14 @@ public Object resolveArgument(MethodParameter parameter, ModelAndViewContainer m
             authId = JwtUtil.getAuthId(token);
             providerType = JwtUtil.getProviderType(token);
 
-            return memberRepository.findByAuthIdAndProviderType(authId, providerType).orElseThrow(NoSuchElementException::new);
+            return memberRepository.findByAuthIdAndProviderType(authId, providerType).orElseThrow(() -> new NoSuchElementException("존재하지 않는 회원: " + authId + " " + providerType));
         }
 
         Optional<Cookie> refreshTokenCookie = CookieUtils.getCookie(request, JwtUtil.REFRESH_TOKEN_NAME);
         token = refreshTokenCookie.orElseThrow(AuthenticationException::new).getValue();
         authId = JwtUtil.getAuthId(token);
         providerType = JwtUtil.getProviderType(token);
 
-        return memberRepository.findByAuthIdAndProviderType(authId, providerType).orElseThrow(NoSuchElementException::new);
+        return memberRepository.findByAuthIdAndProviderType(authId, providerType).orElseThrow(() -> new NoSuchElementException("존재하지 않는 회원: " + authId + " " + providerType));
     }
 }
diff --git a/src/main/java/com/climingo/climingoApi/global/exception/GlobalExceptionHandler.java b/src/main/java/com/climingo/climingoApi/global/exception/GlobalExceptionHandler.java
@@ -5,6 +5,7 @@
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.dao.DataIntegrityViolationException;
 import org.springframework.http.HttpStatus;
+import org.springframework.http.converter.HttpMessageNotReadableException;
 import org.springframework.security.access.AccessDeniedException;
 import org.springframework.web.bind.MethodArgumentNotValidException;
 import org.springframework.web.bind.MissingServletRequestParameterException;
@@ -55,4 +56,9 @@ public ExceptionResponse handleDataIntegrityViolationException(DataIntegrityViol
     public ExceptionResponse handleAccessDeniedException(AccessDeniedException e) {
         return ExceptionResponse.of(HttpStatus.FORBIDDEN.getReasonPhrase(), e.getMessage());
     }
+
+    @ExceptionHandler(HttpMessageNotReadableException.class)
+    public ExceptionResponse handleHttpMessageNotReadableException(HttpMessageNotReadableException e) {
+        return ExceptionResponse.of(HttpStatus.BAD_REQUEST.getReasonPhrase(), e.getMessage());
+    }
 }
diff --git a/src/main/java/com/climingo/climingoApi/member/api/MemberController.java b/src/main/java/com/climingo/climingoApi/member/api/MemberController.java
@@ -1,10 +1,12 @@
 package com.climingo.climingoApi.member.api;
 
 import com.climingo.climingoApi.global.auth.LoginMember;
+import com.climingo.climingoApi.member.api.request.UpdateNicknameRequest;
 import com.climingo.climingoApi.member.application.MemberService;
-import com.climingo.climingoApi.member.application.response.MemberInfoResponse;
-import com.climingo.climingoApi.member.application.response.ProfileResponse;
+import com.climingo.climingoApi.member.api.response.MemberInfoResponse;
+import com.climingo.climingoApi.member.api.response.ProfileResponse;
 import com.climingo.climingoApi.member.domain.Member;
+import jakarta.validation.Valid;
 import lombok.RequiredArgsConstructor;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.GetMapping;
@@ -32,8 +34,8 @@ public ResponseEntity<MemberInfoResponse> findMemberInfo(@PathVariable(value = "
     }
 
     @PatchMapping("/members/{memberId}/nickname")
-    public ResponseEntity<Void> updateNickname(@LoginMember Member member, @PathVariable(value = "memberId") Long memberId, @RequestBody String nickname) {
-        memberService.updateNickname(member, memberId, nickname);
+    public ResponseEntity<Void> updateNickname(@LoginMember Member member, @PathVariable(value = "memberId") Long memberId, @RequestBody @Valid UpdateNicknameRequest request) {
+        memberService.updateNickname(member, memberId, request.getNickname());
         return ResponseEntity.ok().build();
     }
 }
diff --git a/src/main/java/com/climingo/climingoApi/member/api/request/UpdateNicknameRequest.java b/src/main/java/com/climingo/climingoApi/member/api/request/UpdateNicknameRequest.java
@@ -0,0 +1,17 @@
+package com.climingo.climingoApi.member.api.request;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import jakarta.validation.constraints.NotNull;
+import lombok.Builder;
+import lombok.Getter;
+
+@Builder
+@Getter
+@JsonDeserialize(builder = UpdateNicknameRequest.UpdateNicknameRequestBuilder.class)
+public class UpdateNicknameRequest {
+
+    @JsonProperty("nickname")
+    @NotNull
+    private final String nickname;
+}
diff --git a/...lication/response/MemberInfoResponse.java → ...mber/api/response/MemberInfoResponse.java b/...lication/response/MemberInfoResponse.java → ...mber/api/response/MemberInfoResponse.java
@@ -1,4 +1,4 @@
-package com.climingo.climingoApi.member.application.response;
+package com.climingo.climingoApi.member.api.response;
 
 import com.climingo.climingoApi.member.domain.Member;
 import lombok.Getter;

diff --git a/...application/response/ProfileResponse.java → .../member/api/response/ProfileResponse.java b/...application/response/ProfileResponse.java → .../member/api/response/ProfileResponse.java
@@ -1,4 +1,4 @@
-package com.climingo.climingoApi.member.application.response;
+package com.climingo.climingoApi.member.api.response;
 
 import com.climingo.climingoApi.record.api.response.RecordResponse;
 import java.util.List;

diff --git a/src/main/java/com/climingo/climingoApi/member/application/MemberService.java b/src/main/java/com/climingo/climingoApi/member/application/MemberService.java
@@ -1,7 +1,7 @@
 package com.climingo.climingoApi.member.application;
 
-import com.climingo.climingoApi.member.application.response.MemberInfoResponse;
-import com.climingo.climingoApi.member.application.response.ProfileResponse;
+import com.climingo.climingoApi.member.api.response.MemberInfoResponse;
+import com.climingo.climingoApi.member.api.response.ProfileResponse;
 import com.climingo.climingoApi.member.domain.Member;
 
 public interface MemberService {

diff --git a/src/main/java/com/climingo/climingoApi/member/application/MemberServiceImpl.java b/src/main/java/com/climingo/climingoApi/member/application/MemberServiceImpl.java
@@ -4,8 +4,8 @@
 import com.climingo.climingoApi.auth.api.response.MemberInfo;
 import com.climingo.climingoApi.auth.application.SignInService;
 import com.climingo.climingoApi.auth.application.SignUpService;
-import com.climingo.climingoApi.member.application.response.MemberInfoResponse;
-import com.climingo.climingoApi.member.application.response.ProfileResponse;
+import com.climingo.climingoApi.member.api.response.MemberInfoResponse;
+import com.climingo.climingoApi.member.api.response.ProfileResponse;
 import com.climingo.climingoApi.member.domain.Member;
 import com.climingo.climingoApi.member.domain.MemberRepository;
 import com.climingo.climingoApi.record.api.response.RecordResponse;