Fix/390: [FE] [녹음] 녹음을 중단하면 녹음이 저장되지 않고 바로 삭제될 수 있도록 수정 #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SingTheCode
approved these changes
Jan 23, 2024
| @@ -6,21 +6,31 @@ import useAudios from "hooks/useAudios"; | |||
|
|
|||
| import UnderPlayBar from "components/blocks/UnderPlayBar"; | |||
|
|
|||
| function UnderPlayBarViewModel() { | |||
| function UnderPlayBarViewModel({ isRecording }: { isRecording?: boolean }) { | |||
There was a problem hiding this comment.
파라미터에 default 값을 부여해서 타입 에러를 피할 수도 있을 것 같아요ㅎㅎ
- 녹음 중이거나 트랙이 있는 경우에만 재생 - 트랙이 변경되면 초기화
gxxrxn
force-pushed
the
feat/fe/Issue-390
branch
from
845fe3d
to
9717478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#407 PR 리뷰, 머지한 후에 확인해주세요!
구현 기능
fix: 녹음 중 삭제 기능 구현
interruptedflag 전달fix: track player 재생 조건 수정
fix: 프로젝트 생성 녹음 상태 하단 재생바에 전달
isRecordingprops 전달공유하고 싶은 내용
관련 이슈