-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to define custom grid in ABF biases #710
Conversation
It is good to see that the grid parameters can be separated from the |
No, I can't think of a use case for having CZAR on a different grid. |
c6a0ea8
to
21aecfe
Compare
@jhenin I am reviewing this, and as you know I like the approach (see #476), but I am also remembering now an unwanted consequence of encouraging the users to use custom definitions of the grid as their go-to option. Metadynamics exhibits artifacts when the system routinely samples states that are too close to the grid boundaries, as you know. https://colvars.github.io/master/colvars-refman-namd.html#sec:colvarbias_meta_boundaries The current code and documentation are now encouraging users to just use the mathematical boundaries of the CVC functions (see #310), i.e. not define grid boundaries themselves when default values are available. If we merge this PR (as I think we will very soon), we would also need to improve the code introduced in #310 and let it check that each user-provided boundary matches the default given by the CVCs. Would you be okay with waiting to contribute to the MD engine distributions until these changes are also merged? |
7ad1615
to
68083b4
Compare
Implement in colvargid::init_from_colvars Clean up unused grid constructors
For consistency. Update doc and tests. histogramGrid is deprecated but still works.
this allows for transparent initialization of a grid from another contining a different data type.
This is now superseded by #733 |
This creates a new keyword,
gridParameters
, which mimicshistogramGrid
within a histogram bias.In the process, unify both keywords under the new name and deprecate
histogramGrid
.See Issue #476
TODO: