Skip to content

Commit

Permalink
Merge pull request #3242 from CombatExtended-Continued/Resolve-Loop
Browse files Browse the repository at this point in the history
Resolve Vanilla Expanded Dependency Loop
  • Loading branch information
N7Huntsman authored Jul 4, 2024
2 parents ef8fc98 + c686743 commit 2aa6818
Show file tree
Hide file tree
Showing 10 changed files with 122 additions and 80 deletions.
2 changes: 0 additions & 2 deletions About/About.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@
<li>miho.fortifiedoutremer</li>
<li>co.uk.epicguru.whatsthatmod</li>
<li>sarg.alphagenes</li>
<li>OskarPotocki.VFE.Classical</li>
<li>OskarPotocki.VFE.Tribals</li>
</loadBefore>
<loadAfter>
<li>brrainz.harmony</li>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,5 @@
<speed>34</speed>
</projectile>
</ThingDef>

</Defs>
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
<?xml version="1.0" encoding="utf-8"?>
<Defs>

<!-- Roman Shield (Scutum) -->
<ThingDef ParentName="ShieldBase">
<defName>VFEC_Shield_Heavy_CE</defName>
<label>kite shield</label>
<description>A heavily fortified square shield that covers one's body from shin to shoulder, heavy enough to slow those wielding it at the benefit of incredible protection.</description>
<techLevel>Neolithic</techLevel>
<graphicData>
<texPath>Things/Item/Equipment/Shield/HeavyShield/HeavyShield</texPath>
<graphicClass>Graphic_Single</graphicClass>
<drawSize>0.88</drawSize>
</graphicData>
<thingCategories Inherit="False">
<li>Shields</li>
</thingCategories>
<costStuffCount>25</costStuffCount>
<costList>
<WoodLog>60</WoodLog>
<Steel>35</Steel>
</costList>
<stuffCategories>
<li>Leathery</li>
</stuffCategories>
<recipeMaker>
<researchPrerequisite>VFEC_HeavyShieldMaking</researchPrerequisite>
<recipeUsers>
<li>FueledSmithy</li>
<li>ElectricSmithy</li>
</recipeUsers>
</recipeMaker>
<statBases>
<WorkToMake>3000</WorkToMake>
<MaxHitPoints>145</MaxHitPoints>
<StuffEffectMultiplierArmor>2</StuffEffectMultiplierArmor>
<ArmorRating_Sharp>1.75</ArmorRating_Sharp>
<ArmorRating_Blunt>6</ArmorRating_Blunt>
<Mass>8</Mass>
<Bulk>8</Bulk>
<WornBulk>6</WornBulk>
</statBases>
<equippedStatOffsets>
<ReloadSpeed>-0.1</ReloadSpeed>
<MeleeHitChance>-1</MeleeHitChance>
<ShootingAccuracyPawn>-0.2</ShootingAccuracyPawn>
<AimingAccuracy>-0.05</AimingAccuracy>
<Suppressability>-0.25</Suppressability>
<MeleeCritChance>-0.08</MeleeCritChance>
<MeleeParryChance>1.0</MeleeParryChance>
</equippedStatOffsets>
<comps>
<li>
<compClass>CompColorable</compClass>
</li>
</comps>
<apparel>
<developmentalStageFilter>Child, Adult</developmentalStageFilter>
<tags>
<li>TribalShield</li>
</tags>
<renderNodeProperties>
<li>
<nodeClass>CombatExtended.PawnRenderNode_Apparel</nodeClass>
<workerClass>CombatExtended.PawnRenderNodeWorker_Drafted</workerClass>
<texPath>Things/Item/Equipment/Shield/HeavyShield/HeavyShield</texPath>
<shaderTypeDef>CutoutComplex</shaderTypeDef>
<parentTagDef>ApparelBody</parentTagDef>
<drawData>
<scale>0.65</scale>
<defaultData>
<layer>80</layer>
</defaultData>
<dataEast>
<layer>-5</layer>
<offset>(0, 0, -0.1)</offset>
<rotationOffset>30</rotationOffset>
</dataEast>
<dataWest>
<rotationOffset>-30</rotationOffset>
</dataWest>
<dataNorth>
<layer>-5</layer>
<offset>(0.15, 0, -0.1)</offset>
</dataNorth>
<dataSouth>
<offset>(0.3, 0, -0.2)</offset>
</dataSouth>
</drawData>
</li>
</renderNodeProperties>
</apparel>
<modExtensions>
<li Class="CombatExtended.ShieldDefExtension">
<shieldCoverage>
<li>Hands</li>
<li>Arms</li>
<li>Shoulders</li>
<li>Torso</li>
<li>Neck</li>
<li>Legs</li>
</shieldCoverage>
</li>
</modExtensions>
</ThingDef>

</Defs>
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Patch>

<!-- Toga -->

<Operation Class="PatchOperationReplace">
Expand Down Expand Up @@ -148,4 +149,10 @@
</li>
</value>
</Operation>

<!-- Roman Shield (Scutum) -->
<Operation Class="PatchOperationRemove">
<xpath>Defs/ThingDef[defName="VFEC_Shield_Heavy"]</xpath>
</Operation>

</Patch>
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,5 @@
<li>CE_Apparel_TribalBackpack</li>
</value>
</Operation>

</Patch>
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<Patch>

<!-- ========== Scorpion - Turret ========== -->

<Operation Class="PatchOperationRemove">
<xpath>Defs/ThingDef[defName = "VFEC_Turret_Scorpion"]/comps/li[@Class = "CompProperties_Refuelable"]</xpath>
</Operation>
Expand Down Expand Up @@ -65,4 +67,5 @@
</weaponTags>
</value>
</Operation>

</Patch>

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Patch>

<!--One-handed Tags -->
<Operation Class="PatchOperationAdd">
<xpath>Defs/ThingDef[defName = "VFEC_MeleeWeapon_Spatha" or defName="VFEC_MeleeWeapon_Dagger"]/weaponTags</xpath>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Operation Class="PatchOperationAttributeSet">
<xpath>Defs/ThingDef[defName="VFEC_Javelin"]</xpath>
<attribute>ParentName</attribute>
<value>BaseWeaponAndAmmoNeolithic</value>
<value>BaseWeapon</value>
</Operation>

<Operation Class="PatchOperationAttributeAdd">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<Operation Class="PatchOperationAttributeSet">
<xpath>Defs/ThingDef[defName="VFET_Throwspikes"]</xpath>
<attribute>ParentName</attribute>
<value>BaseWeaponAndAmmoNeolithic</value>
<value>BaseWeapon</value>
</Operation>

<Operation Class="PatchOperationAttributeAdd">
Expand Down

0 comments on commit 2aa6818

Please sign in to comment.