Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal Gear Rimworld-Gekko patch #2760

Conversation

HeraldOfTzeentch
Copy link
Contributor

@HeraldOfTzeentch HeraldOfTzeentch commented Sep 16, 2023

Patch for Metal Gear Rimworld-Gekko

IMPORTANT NOTE: game only runs without errors when coverage is fixed on AOBAS end in Metal Gear Rimworld-Gekko (its above 1 total) hes aware and will adress it from what i know so in future should run without errors

Testing

Check tests you have performed:

  • Compiles without warnings
  • [ yes but read important ] Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (10 hours)

@HeraldOfTzeentch HeraldOfTzeentch requested review from a team as code owners September 16, 2023 22:17
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6209890221.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Sep 16, 2023
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6225106310.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just needs some small tweaks to carrying capacity.

<xpath>Defs/ThingDef[defName="MGR_Mech_Gekko"]/statBases</xpath>
<value>
<ArmorRating_Heat>0.25</ArmorRating_Heat>
<CarryWeight>250</CarryWeight>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the Gekko has a bodySize of 4, it can carry 1000 kg (250 * 4). I'd go ahead and reduce this from value 250 to 60, so that it gets an appropriate carry weight with bodySize factored in.

@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6257888531.zip

@N7Huntsman N7Huntsman merged commit 6ae4eef into CombatExtended-Continued:Development Sep 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants