-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Casing mote center to gun draw center #2816
Conversation
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6522703076.zip |
and also randomized mote life span from 0.5 to 1.5. The original ones looks good firing horizontally but looks awful when firing at an angle
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6523098178.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6523216429.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6523467230.zip |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6524607731.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works in testing.
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6584908802.zip |
Changes
Make casing mote originate from where gun draw center is. Works perfect for AR, LMG, pistol and shotguns, sub-optimal but acceptable on SMG, rifle and sniper rifle, a bit hilarous on minigun
Also fixed casing velocity on handheld weapons when firing towards right side
Added casing offset to gundrawextension
Made casing mote life span randomize from 0.5 to 1.5, because the original looked awful when not firing east/west.
before:
after:
Reasoning
We CE people don't pull ammo out of our butts like vanilla does, so casings shouldn't either.
Alternatives
Shit hot brass.
To do
-I actually hated the implementation but I couldn't come up with a better one, unless I copy a good chunk of code from pawnrenderer. Probably need a look from a coder better than me.
-Another modextension for angle offset?
Testing
Check tests you have performed: