Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casing mote center to gun draw center #2816

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Conversation

CMDR-Bill-Doors
Copy link
Contributor

@CMDR-Bill-Doors CMDR-Bill-Doors commented Oct 15, 2023

Changes

Make casing mote originate from where gun draw center is. Works perfect for AR, LMG, pistol and shotguns, sub-optimal but acceptable on SMG, rifle and sniper rifle, a bit hilarous on minigun
Also fixed casing velocity on handheld weapons when firing towards right side
Added casing offset to gundrawextension
Made casing mote life span randomize from 0.5 to 1.5, because the original looked awful when not firing east/west.
before:
CasingImprovePre
after:
CasingImprove2
CasingImprove4

Reasoning

We CE people don't pull ammo out of our butts like vanilla does, so casings shouldn't either.

Alternatives

Shit hot brass.

To do

-I actually hated the implementation but I couldn't come up with a better one, unless I copy a good chunk of code from pawnrenderer. Probably need a look from a coder better than me.
-Another modextension for angle offset?

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (a mag with all vanilla guns)

@CMDR-Bill-Doors CMDR-Bill-Doors requested review from a team as code owners October 15, 2023 07:23
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6522703076.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Oct 15, 2023
and also randomized mote life span from 0.5 to 1.5. The original ones looks good firing horizontally but looks awful when firing at an angle
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6523098178.zip

@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6523216429.zip

@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6523467230.zip

@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6524607731.zip

perkinslr
perkinslr previously approved these changes Oct 19, 2023
N7Huntsman
N7Huntsman previously approved these changes Oct 20, 2023
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works in testing.

@N7Huntsman N7Huntsman dismissed stale reviews from perkinslr and themself via 2bdbd2a October 20, 2023 07:49
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6584908802.zip

@N7Huntsman N7Huntsman merged commit 186f7dd into Development Oct 20, 2023
2 checks passed
@N7Huntsman N7Huntsman deleted the CasingMoteCenter branch October 20, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants