Dynamically add ammo items to vehicle ammo ThingFilter #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respects generic ammo, and no ammo modes.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6527047683.zip |
github-actions
bot
added
the
Download in Comments
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6527766215.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6543229507.zip |
Thorbane
previously approved these changes
Oct 19, 2023
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6570393605.zip |
N7Huntsman
approved these changes
Oct 19, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respects generic ammo, and no ammo modes.
Changes
Vehicle patches should no longer manually assign ammos, they are auto assigned from the ammoset if one is specified and ammo is enabled.
Reasoning
The previous approach duplicated information, allowing data to be out of sync. It also made generic ammo support difficult.
Alternatives
Manually specify both
Testing
Check tests you have performed: