Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Compatibility for Royal Arsenal #2855

Merged
merged 11 commits into from
Jan 26, 2024
Merged

Add Compatibility for Royal Arsenal #2855

merged 11 commits into from
Jan 26, 2024

Conversation

AKEKHQ
Copy link
Contributor

@AKEKHQ AKEKHQ commented Oct 30, 2023 •
edited
Loading

Additions

Add Compatibility for Royal Arsenal mod series

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@AKEKHQ AKEKHQ requested review from a team as code owners October 30, 2023 08:45
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6690331946.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Oct 30, 2023
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6690614442.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7381837993.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7651840581.zip

N7Huntsman
N7Huntsman approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformatted the Thunder Javelin patch. Will want to put together some art for the ammo that more closely matches the CE style, but the patch itself is functional.

N7Huntsman
N7Huntsman requested changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, after a bit more consideration, I'm going to do a bit of re-formatting and clean up the ammo a touch.

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7652089193.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7665745179.zip

N7Huntsman
N7Huntsman approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some revising and reformatted a few things in the patches, and it looks good to go.

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7665780545.zip

@N7Huntsman N7Huntsman merged commit 82962cd into CombatExtended-Continued:Development Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N7Huntsman N7Huntsman N7Huntsman approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
5.6
Status: Testing
Future Changes
Status: Testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AKEKHQ @N7Huntsman