Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intersection improvment #2856

Merged
merged 8 commits into from
Nov 14, 2023
Merged

Intersection improvment #2856

merged 8 commits into from
Nov 14, 2023

Conversation

MaxDorob
Copy link
Contributor

@MaxDorob MaxDorob commented Oct 30, 2023 •
edited
Loading

Changes

  • Inverted crossing check
  • Moved additional collision check after CanCollideWith check (can help to avoid incorrect early interception)

Reasoning

  • Projectiles intercepted instantly:
image

Problems

If p1 and p2 outside of shield but line between them intersect shield, then method returns false.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (tested Centurion shields and VPE shield)

@MaxDorob MaxDorob requested review from a team as code owners October 30, 2023 09:32
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6690848976.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Oct 30, 2023
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6699069982.zip

@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6699253550.zip

@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6703743614.zip

@perkinslr perkinslr force-pushed the Intersection_Improvment branch from 77b6575 to ab80fa2 Compare October 31, 2023 08:25
@github-actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6703873835.zip

@MaxDorob
Changed early out logic
abb8c7b 
Debug statements
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6729717437.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6731109531.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6731153898.zip

@MaxDorob MaxDorob mentioned this pull request Nov 2, 2023
Merged
4 tasks
@SerinaCE
Copy link
Contributor

SerinaCE commented Nov 7, 2023

Dunno if it's in any way similar to this, but #2207

@perkinslr perkinslr merged commit 5196d11 into Development Nov 14, 2023
@perkinslr perkinslr deleted the Intersection_Improvment branch November 14, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perkinslr perkinslr perkinslr requested changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxDorob @SerinaCE @perkinslr