Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update laser visuals #2860

Merged
merged 7 commits into from
Nov 6, 2023
Merged

Update laser visuals #2860

merged 7 commits into from
Nov 6, 2023

Conversation

Keshash
Copy link
Contributor

@Keshash Keshash commented Oct 31, 2023

Additions

Describe new functionality added by your code, e.g.

  • Fixes the xml errors about wrong field names in ProjectileImpactFX mod extension for lasers
  • Gives CE lasers a separate white texture so that colors get assigned properly.
  • Restores original beam textures of VE Lasers

Changes

  • Makes default laser colors a brighter, so that they look more glow-ey
  • Updates Warcasket Astartes Melta patch. The deleted modextension in HALO patch doesn't need to be restored, as it already inherits from base CE laser.

References

Links to the associated issues or other related pull requests, e.g.

Alternatives

Describe alternative implementations you have considered, e.g.

  • The lasers most of the time don't create any impact FX because they are not hitting the ground. Maybe something should be done about this

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (specify how long)

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6710300298.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Oct 31, 2023
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6712035093.zip

Copy link

github-actions bot commented Nov 1, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6718574240.zip

@Keshash Keshash marked this pull request as ready for review November 1, 2023 10:33
@Keshash Keshash requested review from a team as code owners November 1, 2023 10:33
Copy link

github-actions bot commented Nov 3, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6744995654.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably more than just the xml changes at work, but while testing the weapons from VWE: Lasers and VWE: Coilcuns, I had this error spammed. Since the coilgun beams don't appear, I think they're the issue.

Exception drawing BeamGraphic17490: System.NullReferenceException: Object reference not set to an instance of an object
  at CombatExtended.Lasers.LaserBeamDefCE.GetBeamMaterial (System.Int32 index) [0x0000e] in <71e953f724f349d8bdc0c59120a79f0b>:0 
  at CombatExtended.Lasers.LaserBeamGraphicCE.SetupDrawing () [0x00019] in <71e953f724f349d8bdc0c59120a79f0b>:0 
  at CombatExtended.Lasers.LaserBeamGraphicCE.Draw () [0x00001] in <71e953f724f349d8bdc0c59120a79f0b>:0 
  at Verse.DynamicDrawManager.DrawDynamicThings () [0x000d8] in <cd7169108ea74757aa50c5b33d275c15>:0 
UnityEngine.StackTraceUtility:ExtractStackTrace ()
(wrapper dynamic-method) Verse.Log:Verse.Log.Error_Patch1 (string)
Verse.DynamicDrawManager:DrawDynamicThings ()
Verse.Map:MapUpdate ()
Verse.Game:UpdatePlay ()
Verse.Root_Play:Update ()

Copy link

github-actions bot commented Nov 6, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6764770548.zip

@N7Huntsman N7Huntsman merged commit ae2e7fa into Development Nov 6, 2023
2 checks passed
@N7Huntsman N7Huntsman deleted the LaserVisualsUpdate branch November 6, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants