Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Vanilla Races Expanded - Archon #2861

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Patch Vanilla Races Expanded - Archon #2861

merged 1 commit into from
Nov 15, 2023

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Oct 31, 2023

Additions

Reasoning

  • Archon armor has slightly less protection than cataphract armor, but no leg or foot protection. It is lighter and less bulky (owing to superior archotech), making it better suited for melee fighting.
  • Archoblade is plasma sword without stabbing attack and very high Sharp AP, as the weapon is described as "phasing through" armor.

Alternatives

  • Could change some armor values.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners October 31, 2023 22:50
@N7Huntsman N7Huntsman marked this pull request as draft October 31, 2023 22:50
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6713309916.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Oct 31, 2023
@Safairette
Copy link
Contributor

Othen than the already mentioned shield issue, the VE psycast module doesn't reduce the armor properly, only applying to natural armor and things like stoneskin glands. The jump gene ability also seems to ignore armor.

@N7Huntsman N7Huntsman marked this pull request as ready for review November 4, 2023 05:49
Copy link
Contributor

@Safairette Safairette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shield works properly now with the merged change. Psychic warp still doesn't reduce apparel armor, but that's probably best addressed in a separate PR.

@N7Huntsman N7Huntsman merged commit 896cf65 into Development Nov 15, 2023
@N7Huntsman N7Huntsman deleted the VRE-Archon branch November 15, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants