Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework and Fix [KG] World War 2 Patch #2880

Merged
merged 24 commits into from
Nov 26, 2023
Merged

Rework and Fix [KG] World War 2 Patch #2880

merged 24 commits into from
Nov 26, 2023

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Nov 9, 2023

Changes

  • Overhaul the K4G WW2 patch pretty much completely.

Reasoning

  • The existing version of the patch simply uses PatchOpReplace to overwrite entire Defs, rather than a more exact method. I went through and implemented more proper versions of the operations, only touching what needed to be touched. This is less cumbersome, and significantly reduces the overall size of the patch files.
  • Balancing should be reasonable, but I didn't go through and generate stats from the spreadsheets for every weapon and projectile. Still, the balance should be acceptable despite some minor inconsistencies (for instance, all types of frag and AT grenade share the same pair of projectile stats, despite some differences between the various individual grenades.)

Alternatives

  • Madness and torment.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners November 9, 2023 05:45
@N7Huntsman N7Huntsman marked this pull request as draft November 9, 2023 05:45
Copy link

github-actions bot commented Nov 9, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6807919899.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 9, 2023
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6820698428.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6821401187.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6821476533.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6821740607.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6821742013.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6822031753.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6844415189.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6845721213.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6846012185.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6857570439.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6859134690.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6899673982.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6911898963.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6942114438.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6942594618.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6952128618.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6964508971.zip

@N7Huntsman N7Huntsman marked this pull request as ready for review November 23, 2023 02:00
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6964742167.zip

Copy link
Contributor

@SerinaCE SerinaCE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Material cost patches completely dropped? could add them back on the baseclasses in a later pr.

Also, lol, completely forgot why I had to replace pawnkind defs, probably improved a lot since.

@N7Huntsman N7Huntsman merged commit 158bed6 into Development Nov 26, 2023
2 checks passed
@N7Huntsman N7Huntsman deleted the KG-WW2 branch November 26, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants