Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Warhammer 40k - Imperium Weaponry + Centralize Warhammer Ammo #2892

Merged
merged 17 commits into from
Jan 12, 2024

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Nov 16, 2023

Additions

  1. Integrate patch for Warhammer 40.000 - Imperium Weaponry.
  2. New ammo sprites for Toxic charged ammo.
  3. Centralize resources for several different Warhammer 40k ammo types.
  • Defs for AmmoSets, Ammo items, and Projectiles have been placed in Warhammer 40k Ammo folder in Defs/Ammo/Modded. One-off unique ammo types can remain within the individual mod patches.
  • Implement the unified ammos in place of the mod-specific ammos.
  • Add the 40k ammo categories to the core CombatExtended.AmmoCategoryDef list in the Advanced file, where categories for several other mods already exist. Remove duplicates from patch files.
  • Add Flecks/Motes for Bolter casing and Melta Flash to the core file of CE flecks/motes. Remove duplicates from patch files.
  1. Revise labels for the Ionising Radiation ammo type.

Changes

  1. Grimworld Autoguns: Change a few weapons from using 5.56mm NATO to more appropriate calibers. .50 BMG for Heavy Stubbed and .44 Mag for the Stub Revolver.
  2. Rotated the melta gun projectile sprite--it was appearing sideways in flight.

References

Closes #2804

Reasoning

  1. At the request of the mod author, as they are not currently able to support/maintain the patch.
  2. A set of tox ammo sprites could potentially be useful in the future and aren't and trouble to add to the files.
  3. We're somewhat overdue to centralize the various 40k ammo resources, given the number of new 40k mods that have been appearing. Centralizing these resources will make it far easier to maintain them and to establish a uniform game balance for them.
  4. The current calibers were likely placeholders that were never replaced. From other media, the revolver uses a large, straight-walled, rimmed cartridge and the Heavy Stubber uses the M2 HMG as a reference in 40k.

Alternatives

  • Different balance schemes.
  • Leave 40k ammos decentralized.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners November 16, 2023 06:12
@N7Huntsman N7Huntsman marked this pull request as draft November 16, 2023 06:13
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6887038533.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 16, 2023
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6887093408.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6887818459.zip

@N7Huntsman N7Huntsman changed the title Patch Warhammer 40k - Imperium Armory + Centralize Warhammer Ammo Patch Warhammer 40k - Imperium Weaponry + Centralize Warhammer Ammo Nov 17, 2023
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6923715510.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6924029052.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6924158302.zip

@N7Huntsman N7Huntsman self-assigned this Nov 20, 2023
@N7Huntsman N7Huntsman marked this pull request as ready for review November 20, 2023 01:09
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6924231374.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-6985700046.zip

@SerinaCE
Copy link
Contributor

would we want to put similar fictional/niche ammodefs in loadfolders (assuming it works fine with subfolders)?
so would only have to load when a relevant mod is present

Copy link

github-actions bot commented Jan 7, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7440272231.zip

Copy link

github-actions bot commented Jan 7, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7440313137.zip

Copy link

github-actions bot commented Jan 7, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7440673212.zip

Copy link

github-actions bot commented Jan 8, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7442258187.zip

Copy link

github-actions bot commented Jan 8, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7442351889.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7483936730.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7486584892.zip

@N7Huntsman N7Huntsman merged commit 6da97b3 into Development Jan 12, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the 40k-Ogam-Patches-2 branch January 12, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Discussion]:unification of WH40K ammo?
2 participants