Misc ammo housekeeping and fixes #2908
Conversation
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7058503030.zip |
github-actions
bot
added
the
Download in Comments
|
While this PR does not fix the attached issue, the changes still are worthy of merging into the dev branch. |
There was a problem hiding this comment.
Everything is working except the mech incendiary shell, which is not replacing the 66mm TB or the 80x256mm FC. No errors and I haven't been able to determine why.
Additionally, we could do with adding a crafting recipe and tags to the 164x284mm Demo rounds, for player-controlled Termites. If we can include that in this PR while poking at other bits of mech ammo, that's just as well.
The recipe is roughly based around the 80mm fuel cells and what has been used so far in the VFE-Mechs patch with appropriate adjustments.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7299709341.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7434663604.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7434732089.zip |
N7Huntsman
merged commit 320668a
into
CombatExtended-Continued:Development
#2874 reopened, the original fork needed to be removed.
Changes
References
Closes [Bug]: Wrong similarTo tags on some calibers #2873
Despite trying various changes and cross-referencing the Demo mech shell with other generic ammo types and making sure things are consistent, none of the mechanoid ammo types get converted into their generic ammo type correctly. 80mm and 66mm ones stay as is and other ammo types like 5x35mm and 12x64mm get converted into manmade generic ammo types instead of the correct mech charged generic ammo type despite the similarTo tag being assigned correctly.
The issue described in # 2873 is apparently caused by a fundamental problem with the system since none of the various tried xml solutions could fix the issue. Simply replacing the generic ammo type to a working one does not fix the problem properly.
-None of the generic mech ammo types except the Demo shells appear ingame inside the dev tools either, it's like they are not being recognized by the ammo injector or something.
Testing
Check tests you have performed: