Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vehicles (and zombies) not having a valid cached CollisionVertical #2913

Draft
wants to merge 3 commits into
base: Development
Choose a base branch
from
Draft

Fix vehicles (and zombies) not having a valid cached CollisionVertical #2913

wants to merge 3 commits into from

Conversation

perkinslr
Copy link
Contributor

Changes

If a pawn lacks a tactical manager, it cannot cache its collision vertical, so fall back to old behavior.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@perkinslr perkinslr requested review from a team as code owners December 4, 2023 05:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7082535747.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Dec 4, 2023
N7Huntsman
N7Huntsman requested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I equipped a drafted colonist with a molotov and hovered over an unoccupied vehicle, spamming this error: https://pastebin.com/TfBV6sRv

Testing with the current dev build assembly, I get the same issue, so it appears this may not have resolved the issue.

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7244078693.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7244457194.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7244503511.zip

@perkinslr perkinslr force-pushed the fix-cached-height-vehicles branch from 1cf84bd to 960f39d Compare December 18, 2023 07:50
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7245106352.zip

@perkinslr perkinslr marked this pull request as draft January 22, 2024 06:49
@N7Huntsman N7Huntsman added the On Hold Being held until after the next release. label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N7Huntsman N7Huntsman N7Huntsman requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available. On Hold Being held until after the next release.
Projects
5.6
Status: Postponed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@perkinslr @N7Huntsman