Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for Thrumbo Plushie #2916

Merged

Conversation

Dev-LyonLee
Copy link
Contributor

Create ThrumboPlushie item patch.

Additions

Describe new functionality added by your code, e.g.

  • Tribal smoke bombs
  • New tribal smoke bomb sprite
  • Tribal smoke bomb recipes at smithing bench and crafting spot using prometheum

Changes

Describe adjustments to existing features made in this merge, e.g.

  • Increased regular smoke bomb radius

References

Links to the associated issues or other related pull requests, e.g.

  • Closes #[ISSUE_NUMBER]
  • Contributes towards #[ISSUE_NUMBER]

Reasoning

Why did you choose to implement things this way, e.g.

  • Tribals need ways to close distance with pirate raiders
  • Smoke bombs allow this while enhancing combat micro
  • Thematically appropriate as we already allow tribal prometheum handling
  • Easy to implement
  • Buffed regular smoke grenades as they are rarely utilized and to justify additional investment

Alternatives

Describe alternative implementations you have considered, e.g.

  • Tribal catapult that launches melee animals into siege camps:
    • Additional use for animals
    • Anachronistic
    • Breaks realism theme

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

Create ThrumboPlushie item patch.
@Dev-LyonLee Dev-LyonLee requested review from a team as code owners December 6, 2023 04:37
Copy link

github-actions bot commented Dec 6, 2023

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7110241050.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Dec 6, 2023
SerinaCE
SerinaCE previously approved these changes Dec 10, 2023
@N7Huntsman
Copy link
Contributor

Merge w/o building for now. Build bot issue is unrelated.

@N7Huntsman N7Huntsman merged commit f7abc40 into CombatExtended-Continued:Development Dec 14, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants