Generic ammo user for auto loader (very experimental) #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7208920371.zip |
github-actions
bot
added
the
Download in Comments
perkinslr
requested changes
Jan 22, 2024
Source/CombatExtended/CombatExtended/Jobs/Utils/JobGiverUtils_Reload.cs
Outdated
Show resolved
Hide resolved
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9860844661.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9860941672.zip |
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9937405225.zip |
hide ammosets with completely identical ammo. Hovering mouse over a caliber shows contained ammo's label
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9976084936.zip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Ammouser subclass that can select between all calibers it shares "similar to" with.
Changes
Shit ton of code to accomodate the change.
This PR was considered experimental due to it fiddle with ammo loading jobs. Need playtesting
Reasoning
Nooo you can't put 7.62x51 ammo in a 7.62x54R auto loader, we need an auto loader for anything from .22lr to 155mm howitzer!
Alternatives
Suffer.
Testing
Check tests you have performed: