Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casing Filth Housekeeping #2940

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Casing Filth Housekeeping #2940

merged 2 commits into from
Jan 22, 2024

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Jan 9, 2024 •
edited
Loading

Changes

  • No functional changes. Simply consolidates the filth defs a bit, creating a unified parent (BaseFilth_CE) to reduce some redundancy since, aside from label and sprites, the filth defs have the same stats.

Reasoning

  • Housekeeping and general good practice.

Alternatives

  • Could leave it as-is.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners January 9, 2024 07:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7458179092.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jan 9, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7580314162.zip

@N7Huntsman N7Huntsman merged commit 9e75afc into Development Jan 22, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the Filth-Housekeeping branch January 22, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perkinslr perkinslr perkinslr approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N7Huntsman @perkinslr