Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ammoConsumedPerShot to ammosetdefs #2941

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Conversation

perkinslr
Copy link
Contributor

Additions

Describe new functionality added by your code, e.g.

  • A new field is added to ammoSetDefs to support modifying ammo used per shot across entire ammosets. Mostly matters for vehicles.
  • The existing per-verb property is left unmodified, but the effects multiply

Reasoning

  • Vehicles do not have ammosets, so moving the value to the ammoset is the simplest way to expose the data for VF use.
  • Multi-verb frameworks might want to set different values for different verbs, so removing the value from the verbs is probably a poor choice.

Alternatives

Describe alternative implementations you have considered, e.g.

  • Explicitly add a separate mult value for vehicles to use
  • Disable the per-verb value

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@perkinslr perkinslr requested review from a team as code owners January 9, 2024 10:59
Copy link

github-actions bot commented Jan 9, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7460180301.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7460191546.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in testing.

@N7Huntsman N7Huntsman merged commit 39357a1 into Development Jan 15, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the ammo-consumed-per-shot branch January 15, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants