Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Early intercept fix #2945

Open
wants to merge 48 commits into
base: Development
Choose a base branch
from
Open

Early intercept fix #2945

wants to merge 48 commits into from

Conversation

MaxDorob
Copy link
Contributor

@MaxDorob MaxDorob commented Jan 12, 2024 •
edited
Loading

Changes

  • Before collide with smth, we check other possible targets;
  • Calback changes.

Reasoning

  • If pawn stay out of a shield, that uses CheckForCollisionBetweenCallback, bullet may avoid a pawn and hit the shield behind the pawn
    image
    image
    image

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (tested the same situations)

@MaxDorob MaxDorob requested review from a team as code owners January 12, 2024 14:18
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7503363278.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jan 12, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7503383661.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7503412122.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7503467205.zip

This was referenced Jan 12, 2024
Closed
Closed
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7571720360.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7571757583.zip

N7Huntsman
N7Huntsman previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In testing, it does seem to reduce the instances of projectiles hitting the shield that it seems like the pawn standing on the neighboring cell should've been hit by.

@N7Huntsman
Copy link
Contributor

We'll hold off on this and the associated PRs after the 5.6 release.

@N7Huntsman N7Huntsman marked this pull request as draft January 22, 2024 06:49
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8269012545.zip

@MaxDorob MaxDorob marked this pull request as ready for review March 13, 2024 17:49
@MaxDorob MaxDorob requested a review from perkinslr March 13, 2024 17:49
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8278582531.zip

@perkinslr perkinslr marked this pull request as draft March 25, 2024 04:37
@N7Huntsman N7Huntsman added the On Hold Being held until after the next release. label Mar 25, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9245488272.zip

@MaxDorob MaxDorob marked this pull request as ready for review May 26, 2024 18:55
@MaxDorob MaxDorob requested a review from N7Huntsman May 27, 2024 18:25
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11281272013.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11281280706.zip

@MaxDorob MaxDorob removed the On Hold Being held until after the next release. label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perkinslr perkinslr Awaiting requested review from perkinslr

@N7Huntsman N7Huntsman Awaiting requested review from N7Huntsman

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxDorob @N7Huntsman @perkinslr