Laser damage type #2959
Merged
Laser damage type #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
separate laser damage def that applies burn damage and checks against sharp armor
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7595794099.zip |
github-actions
bot
added
the
Download in Comments
Thorbane
previously approved these changes
Jan 29, 2024
N7Huntsman
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new laser damageDef, applies burn damage while properly checking against sharp armor, applied to relevant projectiles in patches.
Reasoning:
it was stupid. most of the laser projectiles had assinged sharp penetration values which wouldn't have been put there if patcher didn't want them to get used.
Current setup with burn damagedef on most is literally broken OP.
Testing:
tested new damage def ingame, was working as it should