Handle apparel that isn't armor more gracefully #2972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7739752141.zip |
github-actions
bot
added
the
Download in Comments
perkinslr
force-pushed
the
handle-0-protection-armor
branch
from
6e4f2dd to
2a52401
Compare
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7748393987.zip |
N7Huntsman
approved these changes
Feb 17, 2024
MaxDorob
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If apparel offers 0 protection against sharp, blunt, or fire, don't warn when the pen system can't handle it gracefully.
Reasoning
Avoids log spam for nv goggles and the like.
Alternatives
implement our own warnOnce like function to not drop red errors in the log
Testing
Check tests you have performed: