Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch [K4G] Empires of Old - Core & Factions #2984

Merged
merged 7 commits into from
Feb 24, 2024
Merged

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Feb 7, 2024

Additions

  • Patch new apparel, weapons, and factions from the [K4G] Kingdoms of Old mod series.
    • Wherever possible, used patches from existing equipment as templates. Should be reasonably balanced.
  • Patch factions added by the various K4G submods, adding ammo to pawnkinds and adjusting the Sultanate traders.

Reasoning

Many of the items were already patched in other places, or were comparable enough to patch with a few stat tweaks. Tried to stick reasonably close to vanilla balance.

Switched the 'bolter' from basically a very crude dart gun into a crude 9mm pistol, since the single, crappy weapon wasn't really worth making a whole new ammoset for.

Have to load the Sultanate faction before CE, because it otherwise adds a duplicate weaponTag field to the vanilla Bolt Action Rifle.

Alternatives

  • Could take a different balancing approach to make mod equipment more unique.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners February 7, 2024 02:44
Copy link

github-actions bot commented Feb 7, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7809220596.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Feb 7, 2024
@N7Huntsman N7Huntsman changed the title Patch [K4G] Empires of Old Patch [K4G] Empires of Old - Core Feb 7, 2024
@N7Huntsman
Copy link
Contributor Author

To Do: Patch the various factions, which are pretty much only require the PawnKindDefs to have ammo added as needed.

@N7Huntsman N7Huntsman changed the title Patch [K4G] Empires of Old - Core Patch [K4G] Empires of Old - Core & Factions Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7823007485.zip

@N7Huntsman N7Huntsman merged commit deb6112 into Development Feb 24, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the K4G-EmpiresOfOld branch February 24, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants