-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch [K4G] Empires of Old - Core & Factions #2984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7809220596.zip |
To Do: Patch the various factions, which are pretty much only require the PawnKindDefs to have ammo added as needed. |
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7823007485.zip |
Thorbane
approved these changes
Feb 21, 2024
Safairette
approved these changes
Feb 21, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Reasoning
Many of the items were already patched in other places, or were comparable enough to patch with a few stat tweaks. Tried to stick reasonably close to vanilla balance.
Switched the 'bolter' from basically a very crude dart gun into a crude 9mm pistol, since the single, crappy weapon wasn't really worth making a whole new ammoset for.
Have to load the Sultanate faction before CE, because it otherwise adds a duplicate
weaponTag
field to the vanilla Bolt Action Rifle.Alternatives
Testing
Check tests you have performed: