Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch OutsideSquishy from body part group to body part def tag #2985

Closed
wants to merge 8 commits into from

Conversation

AluminumAlman
Copy link
Contributor

Additions

  1. Created new OutsideSquishy body part tag def.

Changes

  1. Source code checks for OutsideSquishy tag instead of OutsideSquishy group;
  2. Removed OutsideSquishy group from patches which use only Vanilla's body parts;
  3. Patched some of Vanilla's body part defs to use the OutsideSquishy tag;
  4. Unwrap DamageOutsideSquishy's if-statements.

Reasoning

  1. Needed for the other changes;
  2. To use the OutsideSquishy tag instead of the group;
  3. Does not cause errors, but the group doesn't affect anything anymore (stale patches);
  4. To have the same observable behavior on humans as before, with the added bonus of it being applied to animals, too;
  5. Cleaner code.

Alternatives

  • Go over every mod patch to have OutsideSquishy on animal eyes, noses and jaws.
    • Is more flexible;
    • Requires a lot of effort and time (in other words, I'm lazy).

Testing

  • Compiles without warnings;
  • Game runs without errors;
  • Playtested a colony;
  • Tested against humans by debug-applying damage to the eyes.

Copy link

github-actions bot commented Feb 7, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7817816087.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Feb 7, 2024
Copy link

github-actions bot commented Feb 7, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7818378460.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7854727518.zip

@AluminumAlman AluminumAlman marked this pull request as ready for review February 10, 2024 12:07
@AluminumAlman AluminumAlman requested review from a team as code owners February 10, 2024 12:07
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7854798709.zip

MaxDorob
MaxDorob previously approved these changes Mar 14, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8310864003.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8310876199.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8310876181.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8310886544.zip

@SerinaCE SerinaCE requested a review from MaxDorob March 21, 2024 13:56
@N7Huntsman N7Huntsman added the On Hold Being held until after the next release. label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available. On Hold Being held until after the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants