Added support for All-Tech melee #2986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7827634774.zip |
github-actions
bot
added
the
Download in Comments
N7Huntsman
reviewed
Feb 10, 2024
| <!-- Patch stats --> | ||
|
|
||
| <li Class="PatchOperationReplace"> | ||
| <xpath>Defs/ThingDef[contains(defName, |
There was a problem hiding this comment.
This is a rather strange piece of xpath. Why do it this way versus the usual way, if I may ask? Is there something strange in the mod's xml that makes it necessary?
There was a problem hiding this comment.
It's a standard xpath, not sure what you mean by strange. Just wanted all of them to have the same cost in stuff.
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7868301546.zip |
N7Huntsman
requested changes
Feb 12, 2024
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-7875734768.zip |
N7Huntsman
approved these changes
Feb 17, 2024
N7Huntsman
merged commit 95f4022
into
CombatExtended-Continued:Development
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Describe new functionality added by your code, e.g..
Changes
Added compatibility for All-Tech Melee
References
Mod: [https://steamcommunity.com/sharedfiles/filedetails/?id=2789794530](All-Tech Melee)
Reasoning
It was not compatible and we lack good simple melee weapon mods.
Alternatives
no alternatives considered
Testing
Check tests you have performed: