Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRE fix for turrets #3097

Merged
merged 2 commits into from
Apr 22, 2024
Merged

NRE fix for turrets #3097

merged 2 commits into from
Apr 22, 2024

Conversation

MaxDorob
Copy link
Contributor

Changes

  • Fixed NRE

Reasoning

  • Turrets not working

Alternatives

  • Ignore turrets.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (tested few turrets)

@MaxDorob MaxDorob requested review from a team as code owners April 20, 2024 11:23
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8764679133.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Apr 20, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8767042086.zip

Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mortars, manned turrets, and auto turrets can now properly fire.

@N7Huntsman N7Huntsman merged commit f7091d1 into Development Apr 22, 2024
2 checks passed
@N7Huntsman N7Huntsman deleted the Turret_NRE_Fix branch April 22, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants