Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannon shell ammoset updates and general shell housekeeping #3104

Merged
merged 15 commits into from
May 30, 2024
Merged

Cannon shell ammoset updates and general shell housekeeping #3104

merged 15 commits into from
May 30, 2024

Conversation

SamaelGray
Copy link
Contributor

@SamaelGray SamaelGray commented Apr 23, 2024 •
edited
Loading

Additions

  • AP and APCR (Sabot in CE terms mechanically speaking) ammo types for the 76.2mm and 90mm cannon shell ammosets.
  • Two new recipe bases for artillery and cannon shells. The former requiring Mortars research and the latter requiring CE's heavy weapons tech.
  • Expanded the 57mm Bofors ammoset similar to 40mm Bofors L/70.
  • Added the APCR ammo category to both the AmmoCategories file and projectile spreadsheet with a unique crafting recipe.

Changes

  • Changed the recipe bases for shells that corresponded to the added recipe bases. HEAT ammo type requires CE's launcher tech and cannon shells require CE's heavy weapons prerequisite.
  • Minor file structure housekeeping and flavor text fixes/standardizations.
  • Updated some of the tank, cannon and RPG grenade ammo and projectile textures.
  • Fixed the name of 57mm Bofors from 57x483 to the correct 57x438.

References

Reasoning

  • 90mm and 76.2mm shells both have AP and APCR ammo types irl which were absent in CE, the aforementioned ammo types are cheap and performing alternatives to the default HEAT ammo type.
  • The two ammo recipe parent defs, especially the cannon one, were overdue as shells did not have a proper research prerequisite and were unlocked after Machining research.
  • HEAT shells are inside the launcher tech as it's the place for CE's shaped charge ammo types, cannon shells require heavy weapons tech as the platforms using them are unlocked via that project.
  • The new ammo types and recipe parent nodes had to be added and changed in the same PR/branch because of dependencies on each other.
  • 57mm Bofors has AP and programmable HE shells irl.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (Ammo types and research prerequisites work as intended)

@SamaelGray SamaelGray requested review from a team as code owners April 23, 2024 21:59
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8807745762.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Apr 23, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8819102062.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8828661938.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8828989691.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-8829169020.zip

@SamaelGray SamaelGray changed the title 90mm and 76.2mm ammoset updates and general shell housekeeping Cannon shell ammoset updates and general shell housekeeping May 12, 2024
@SamaelGray SamaelGray marked this pull request as draft May 13, 2024 04:32
@SamaelGray SamaelGray marked this pull request as ready for review May 13, 2024 07:42
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9059235379.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9059252085.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9139228257.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9171680667.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9171769096.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9250367618.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9250641324.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9251254858.zip

@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-9296067095.zip

@N7Huntsman N7Huntsman merged commit d3c4696 into CombatExtended-Continued:Development May 30, 2024
2 checks passed
@SamaelGray SamaelGray deleted the SamaelGray-ShellsUpdated branch May 30, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N7Huntsman N7Huntsman N7Huntsman approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamaelGray @N7Huntsman